Skip to content

Conversation

@damien-urruty-sonarsource
Copy link
Contributor

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Only display stdout for failed medium tests SLCORE-1866 Only display stdout for failed medium tests Nov 28, 2025
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Nov 28, 2025

SLCORE-1866

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/reduce-mediumtests-verbosity branch 5 times, most recently from 603a2fd to 6b147c9 Compare December 1, 2025 08:40
@sonarqube-next
Copy link

sonarqube-next bot commented Dec 1, 2025

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/reduce-mediumtests-verbosity branch 3 times, most recently from 8f8cc0c to feeec7f Compare December 9, 2025 14:34
@damien-urruty-sonarsource damien-urruty-sonarsource marked this pull request as ready for review December 9, 2025 16:29
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
General concern - sometimes during investigation I compare correct logs flow with logs of the broken test. So sometimes we need the full log of the green test.
Can we think of a way to enable verbose mode if needed?

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/reduce-mediumtests-verbosity branch from feeec7f to 52cab82 Compare December 9, 2025 17:02
@damien-urruty-sonarsource damien-urruty-sonarsource changed the title SLCORE-1866 Only display stdout for failed medium tests SLCORE-1866 Make tests run less verbose Dec 9, 2025
@damien-urruty-sonarsource damien-urruty-sonarsource changed the title SLCORE-1866 Make tests run less verbose SLCORE-1866 Make test runs less verbose Dec 9, 2025
@damien-urruty-sonarsource
Copy link
Contributor Author

@kirill-knize-sonarsource thanks for your feedback, after considering it I decided to change a bit the implementation: I will still print medium test logs to stdout but redirect them to files thanks to a Maven option. Those files will be part of the archive we attach to GH at the end of the run

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/reduce-mediumtests-verbosity branch from 52cab82 to d3db9a8 Compare December 10, 2025 07:47
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/dam/reduce-mediumtests-verbosity branch from d3db9a8 to 59c3564 Compare December 10, 2025 08:42
@sonarqube-next
Copy link

sonarqube-next bot commented Dec 10, 2025

@damien-urruty-sonarsource damien-urruty-sonarsource merged commit e26e67c into master Dec 10, 2025
20 of 21 checks passed
@damien-urruty-sonarsource damien-urruty-sonarsource deleted the task/dam/reduce-mediumtests-verbosity branch December 10, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants