Skip to content

SCAN4NET-1003 Add CSharp.SDK.9 IT #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alex-meseldzija-sonarsource merged 2 commits into from
Nov 11, 2025
Merged

SCAN4NET-1003 Add CSharp.SDK.9 IT #2922

alex-meseldzija-sonarsource merged 2 commits into from
Nov 11, 2025

Conversation

@alex-meseldzija-sonarsource
Copy link
Contributor

@alex-meseldzija-sonarsource alex-meseldzija-sonarsource commented Nov 5, 2025 •
edited by atlassian bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Add CSharp.SDK.9 IT SCAN4NET-1003 Add CSharp.SDK.9 IT Nov 5, 2025
@alex-meseldzija-sonarsource alex-meseldzija-sonarsource changed the base branch from master to alex/SCAN4NET-100000 November 5, 2025 13:34
@alex-meseldzija-sonarsource alex-meseldzija-sonarsource force-pushed the alex/add-dotnet9sdk-it branch 3 times, most recently from a48de46 to a7e4c3e Compare November 5, 2025 14:57
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Nov 6, 2025
View reviewed changes
its/projects/CSharp.SDK.9/Main/Common.cs
@@ -0,0 +1,8 @@
namespace CSharp.SDKs
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in

  • its/projects/CSharp.SDK.8
  • its/projects/CSharp.SDK.9
  • its/projects/CSharp.SDK.Latest

are completely identical with these exceptions

  • global.json
  • TargetFramework in the csprojs
  • PackageReferences in the UT projects

I would use only a single project (propably its/projects/CSharp.SDK.Latest) and

  • Create a global.json with the SDK (or no global.json) inside the UT
  • Run the build with a /p:TargetFramework={0} argument inside the UT
  • Use the PackageReferences as defined in CSharp.SDK.Latest
  • Make the sdk8(), sdk9(), sdkLatest() a single parameterized test

What do you think?

Copy link
Contributor Author

@alex-meseldzija-sonarsource alex-meseldzija-sonarsource Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me!

Copy link
Contributor Author

@alex-meseldzija-sonarsource alex-meseldzija-sonarsource Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cant use global.json as we use specific versions of msbuild to build these projects.
We cant use File linking, as when the test is copied across to a temp directory it doesn't bring the other files with it. 😭

Base automatically changed from alex/SCAN4NET-100000 to master November 7, 2025 07:45
@alex-meseldzija-sonarsource alex-meseldzija-sonarsource force-pushed the alex/add-dotnet9sdk-it branch 2 times, most recently from a7d060e to c307c03 Compare November 7, 2025 08:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

SonarQube reviewer guide

Summary: Adds C# .NET 9.0 SDK project for integration testing with SonarQube analysis.

Review Focus: Verify the test project structure matches existing SDK patterns and contains appropriate SonarQube rule violations for testing. Check that the Java test correctly validates the new SDK 9 project.

Start review at: its/projects/CSharp.SDK.9/Main/Common.cs. This contains the core test logic with intentional SonarQube rule violations that need to be detected by the analysis engine.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-meseldzija-sonarsource alex-meseldzija-sonarsource marked this pull request as ready for review November 11, 2025 10:29
@alex-meseldzija-sonarsource alex-meseldzija-sonarsource merged commit 4acc954 into master Nov 11, 2025
17 checks passed
@alex-meseldzija-sonarsource alex-meseldzija-sonarsource deleted the alex/add-dotnet9sdk-it branch November 11, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-meseldzija-sonarsource @martin-strecker-sonarsource