SONARPHP-1838 fix: remove superfluous 'throws Exception' declarations from test methods

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Removed unnecessary 'throws Exception' declarations from 5 test methods across the php-checks module that were flagged by SonarQube rule S1130. These declarations were misleading since the methods do not actually throw any checked exceptions, so removing them improves code clarity and reduces false signals about exception handling.

View Project in SonarCloud

---

Fixed Issues

java:S1130 - Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. • MINOR • View issue

Location: php:php-checks/src/test/java/org/sonar/php/checks/GotoUseCheckTest.java:25

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the test() method in GotoUseCheckTest.java. The method body does not actually throw any checked exception, so declaring 'throws Exception' is unnecessary and reduces code readability. By removing this declaration, the method signature becomes cleaner and compliant with the rule that exceptions listed in throws clauses should actually be thrown by the method's execution path.

--- a/php-checks/src/test/java/org/sonar/php/checks/GotoUseCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/GotoUseCheckTest.java
@@ -25,1 +25,1 @@ class GotoUseCheckTest {
-  void test() throws Exception {
+  void test() {

java:S1130 - Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. • MINOR • View issue

Location: php:php-checks/src/test/java/org/sonar/php/checks/RedefineConstantCheckTest.java:25

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the test method 'test()' in RedefineConstantCheckTest.java. The method body does not actually throw any checked exception, so the 'throws Exception' clause was unnecessary and flagged as a code smell. By removing it, the method signature accurately reflects that no checked exceptions are thrown.

--- a/php-checks/src/test/java/org/sonar/php/checks/RedefineConstantCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/RedefineConstantCheckTest.java
@@ -25,1 +25,1 @@ class RedefineConstantCheckTest {
-  void test() throws Exception {
+  void test() {

java:S1130 - Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. • MINOR • View issue

Location: php:php-checks/src/test/java/org/sonar/php/checks/TooManyLinesInFunctionCheckTest.java:29

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the defaultValue() method in TooManyLinesInFunctionCheckTest.java. The method body does not actually throw any checked exception of type java.lang.Exception, so the throws clause was unnecessary and flagged as a code smell. By removing it, the method signature accurately reflects that no checked exceptions are thrown.

--- a/php-checks/src/test/java/org/sonar/php/checks/TooManyLinesInFunctionCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/TooManyLinesInFunctionCheckTest.java
@@ -29,1 +29,1 @@ class TooManyLinesInFunctionCheckTest {
-  void defaultValue() throws Exception {
+  void defaultValue() {

java:S1130 - Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. • MINOR • View issue

Location: php:php-checks/src/test/java/org/sonar/php/checks/regex/EmptyGroupCheckTest.java:25

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the test method 'test()' in EmptyGroupCheckTest.java. The method body does not actually throw any checked exception, so declaring 'throws Exception' is unnecessary and reduces code readability. This directly addresses the code smell about removing declarations of thrown exceptions that cannot be thrown from the method's body.

--- a/php-checks/src/test/java/org/sonar/php/checks/regex/EmptyGroupCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/regex/EmptyGroupCheckTest.java
@@ -25,1 +25,1 @@ class EmptyGroupCheckTest {
-  void test() throws Exception {
+  void test() {

java:S1130 - Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. • MINOR • View issue

Location: php:php-checks/src/test/java/org/sonar/php/checks/regex/GroupReplacementCheckTest.java:25

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the test method 'test()' in GroupReplacementCheckTest.java. The method body does not actually throw any checked exception, so the 'throws Exception' clause was unnecessary and reduced code readability. By removing it, the method signature is cleaner and no longer declares an exception that cannot be thrown from the method's body.

--- a/php-checks/src/test/java/org/sonar/php/checks/regex/GroupReplacementCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/regex/GroupReplacementCheckTest.java
@@ -25,1 +25,1 @@ class GroupReplacementCheckTest {
-  void test() throws Exception {
+  void test() {

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[hashicorp-vault-sonar-prod]

SONARPHP-1838

[felix-pauck-sonarsource]

LGTM! 👍

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
5 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube