Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-jsp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-jasper</artifactId>
<version>9.0.112</version>
<version>11.0.21</version>
Comment on lines 32 to +35
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change: Tomcat 10+ dropped javax.* in favour of jakarta.*.

The java-jsp module has two source files that use javax.servlet.jsp.* APIs that no longer exist in Tomcat 10+:

  • Jasper.java:39import javax.servlet.jsp.JspFactory;
  • Jasper.java:91JspFactory.setDefaultFactory(new JspFactoryImpl())JspFactoryImpl in Tomcat 11 implements jakarta.servlet.jsp.JspFactory, not javax.servlet.jsp.JspFactory; the types are incompatible
  • JasperOptions.java:25import javax.servlet.jsp.tagext.TagLibraryInfo;
  • JasperOptions.java:212getCache() overrides a method from org.apache.jasper.Options that in Tomcat 11 returns Map<String, jakarta.servlet.jsp.tagext.TagLibraryInfo>; returning javax.* fails to satisfy the interface contract

Tomcat 11 ships no javax.servlet.jsp.* classes; they are all under jakarta.servlet.jsp.*. Both source files will fail to compile, and the entire JSP analysis feature will be non-functional.

All javax.servlet.jsp.* imports in Jasper.java and JasperOptions.java must be migrated to jakarta.servlet.jsp.* before this version bump can land.

Suggested change
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-jasper</artifactId>
<version>9.0.112</version>
<version>11.0.21</version>
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-jasper</artifactId>
<version>9.0.112</version>
<exclusions>
<exclusion>
<groupId>org.eclipse.jdt</groupId>
  • Mark as noise

<exclusions>
<exclusion>
<groupId>org.eclipse.jdt</groupId>
Expand Down Expand Up @@ -97,7 +97,7 @@
<artifactItem>
<groupId>javax</groupId>
<artifactId>javaee-web-api</artifactId>
<version>6.0</version>
<version>8.0.1</version>
</artifactItem>
<artifactItem>
<groupId>javax.servlet</groupId>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.11.2</version>
<version>6.0.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -290,7 +290,7 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-expression</artifactId>
<version>6.2.11</version>
<version>7.0.7</version>
</dependency>
<dependency>
<groupId>commons-io</groupId>
Expand Down
Loading