SONARJAVA-5961 Upgrade sonar-java-jdt to 1.8.0.1483 #5388
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
tomasz-tylenda-sonarsource
force-pushed
the
tt/jdt-1.8
branch
5 times, most recently
from
a551c94 to
585fc88
Compare
tomasz-tylenda-sonarsource
changed the title
tomasz-tylenda-sonarsource
requested a review
from dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource
requested changes
Jan 26, 2026
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
Great job on the upgrade, can we check whether the nullablity annotation makes sense here?
| Token token5 = tokens.get(5); | ||
| assertThat(token5.toString(source)).isEqualTo("/// markdown comment 1\n /// markdown comment 2"); | ||
| assertThat(token5.isComment()).isFalse(); // JDT issue https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3914 | ||
| assertThat(token5.isComment()).isTrue(); |
| return true; | ||
| } | ||
| Type contextConsumerType; | ||
| @Nullable Type contextConsumerType = null; |
Contributor
There was a problem hiding this comment.
Nullability assignment and annotation seem a little redundant. Do we need the annotation?
Contributor
Author
There was a problem hiding this comment.
Removed the annotation.
tomasz-tylenda-sonarsource
requested a review
from dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource
approved these changes
Jan 27, 2026
tomasz-tylenda-sonarsource
force-pushed
the
tt/jdt-1.8
branch
from
cdec918 to
bbd66bd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.