GHA-290 Fix get-jira-version to handle SemVer build metadata separator

[kirill-knize-sonarsource]

No description provided.

[hashicorp-vault-sonar-prod]

GHA-290

[sonar-review-alpha]

Summary

Fixes SemVer build metadata handling in get-jira-version

The action previously failed to parse version strings containing SemVer build metadata (e.g., 5.2.3+80217). The fix adds an initial cut operation to strip everything after the + separator before extracting the major.minor.patch components.

What changed:

• Modified the version extraction pipeline to first remove build metadata (+ cut -d '+' -f 1), then extract semantic version components (cut -d '.' -f 1-3)
• Updated the inline comment to clarify the new behavior

What reviewers should know

For reviewers:

• The fix is minimal and surgical — only 2 lines changed in a single action file
• The change is backwards compatible: versions without + metadata pass through unchanged (the first cut returns the whole string when no + is found)
• The semantic versioning spec supports build metadata via +, so this is a real-world fix, not a theoretical edge case
• No tests are visible in this diff; check if test coverage for this scenario exists elsewhere in the repo

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonar-review-alpha]

The fix itself is correct and backward-compatible — stripping + metadata before the dot-split is the right approach, and versions without + pass through unchanged. However, the test workflow wasn't updated alongside the implementation, leaving a stale copy of the old logic and no coverage for the newly supported input format.

Logic duplication / stale test code

.github/workflows/test-get-jira-version.yml line 88 manually reimplements the action's version-parsing logic:

VERSION=$(echo "$RELEASE_VERSION" | cut -d '.' -f 1-3)

This is the old implementation — the cut -d '+' -f 1 strip is missing. The test input (5.6.7.89) happens to have no +, so CI still passes, but the manually-inlined copy now diverges from the actual implementation. If this step is meant to validate that the env var is set correctly, it should either call the action itself (like the other test steps do) or at minimum mirror the current parsing pipeline.

Missing test case for the bug being fixed

None of the existing tests exercise a version string containing + (e.g., 5.2.3+80217). Adding one would confirm the fix works end-to-end and prevent regressions.

🗣️ Give feedback