Skip to content

GHA-221 Improve automated-release with features required by cloud-security#124

Open
jonas-wielage-sonarsource wants to merge 1 commit intomasterfrom
jw/make-automated-release-cs-ready
Open

GHA-221 Improve automated-release with features required by cloud-security#124
jonas-wielage-sonarsource wants to merge 1 commit intomasterfrom
jw/make-automated-release-cs-ready

Conversation

@jonas-wielage-sonarsource
Copy link
Contributor

Part of

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Improve automated-release with features required by cloud-security GHA-221 Improve automated-release with features required by cloud-security Mar 20, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Mar 20, 2026

GHA-221

@sonarqubecloud
Copy link

@sonar-review-alpha
Copy link

sonar-review-alpha bot commented Mar 20, 2026

Summary

Adds two new features to the automated release workflow:

  1. Rule metadata update check: Introduces require-rule-metadata-update input that runs a rule metadata validation job before release. If changes are detected, a PR is created automatically and the release is blocked until merged—ensuring metadata is always up-to-date.

  2. CLI integration tickets: Adds create-cli-ticket input and implementation to support creating integration tickets in the CLI Jira project, mirroring existing integration ticket patterns (SLI, SLE, etc.)

What reviewers should know

Where to start: Look at the two new input parameters (lines 89-93 and 129-133), then the new update-rule-metadata job (lines 276-325) which shows the validation logic. The metadata check is the most significant change—it modifies the release flow by adding a blocking gate.

Key points for reviewers:

  • The update-rule-metadata job is conditional (only runs if the input is enabled) and properly skipped if not needed
  • It blocks the release with a clear error message and PR link when metadata changes are detected
  • The prepare-release job now depends on update-rule-metadata with correct skip conditions (lines 335-338)
  • CLI ticket creation follows the existing integration ticket pattern—minimal new logic
  • The final results check (line 822) now includes the metadata job, ensuring it's part of success validation

Watch for: The error message in the metadata check tells users to start a new workflow run rather than retry—this is intentional since a metadata PR needs to be merged on master first. Verify this matches your release process expectations.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: Clean, focused PR. Both features follow existing patterns faithfully, the new update-rule-metadata gate integrates correctly into the job dependency chain (including skip propagation and the final results loop), and the CLI ticket step is a straightforward copy of the established integration ticket pattern.

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants