Skip to content

BUILD-10835 Migrate GitHub-hosted Ubuntu runners to warp-custom-ubuntu-24-04#689

Open
SonarTech wants to merge 6 commits into
mainfrom
feat/hnasr/BUILD-10835-migrateGithubUbuntuToWarp
Open

BUILD-10835 Migrate GitHub-hosted Ubuntu runners to warp-custom-ubuntu-24-04#689
SonarTech wants to merge 6 commits into
mainfrom
feat/hnasr/BUILD-10835-migrateGithubUbuntuToWarp

Conversation

@SonarTech
Copy link
Copy Markdown
Contributor

BUILD-10835 This change moves CI from GitHub-hosted Ubuntu runner labels to the shared WarpBuild image warp-custom-ubuntu-24-04, in line with the platform runner migration.

Summary

  • Replaces github-ubuntu-latest-* with warp-custom-ubuntu-24-04 in the workflows listed in the migration scan.

Files

  • .github/workflows/build.yml
  • .github/workflows/PullRequestClosed.yml
  • .github/workflows/PullRequestCreated.yml
  • .github/workflows/releasability.yml
  • .github/workflows/release.yml
  • .github/workflows/unified-dogfooding.yml

Notes for reviewers

  • No intentional changes to job logic, permissions, or steps beyond runs-on / default runner strings.
  • Please confirm workflows still match org expectations for this repository after merge.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit c4dc46a
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a0729b384c5a800082839aa
😎 Deploy Preview https://deploy-preview-689--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 15, 2026

BUILD-10835

@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@hedinasr hedinasr marked this pull request as ready for review May 18, 2026 07:55
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented May 18, 2026

Summary

Straightforward runner migration: Replaces github-ubuntu-latest-s with warp-custom-ubuntu-24-04 across 6 workflow files (7 total changes). All runs-on: replacements are clean line swaps with no job logic or permission changes.

The migration covers primary jobs in build/release/PR/releasability workflows plus slack-notification jobs in several workflows. Changes align with SonarSource's platform-wide shift to WarpBuild runners.

What reviewers should know

Verification points:

  • The slack-notification jobs retain comments stating "Public GH runner is required" — confirm warp-custom-ubuntu-24-04 satisfies this requirement (the comment implies certain GitHub Actions may not run on custom runners)
  • Check workflow execution after merge in at least one non-main branch to catch any environment-specific issues before it reaches production workflows

Where to review:

  • Start with the smaller files (PullRequestClosed.yml, PullRequestCreated.yml) to confirm the pattern
  • Pay extra attention to the slack-notification jobs in build.yml and release.yml, which have the "public runner required" caveat
  • No interdependencies between the changes — each file can be reviewed independently

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused migration — all 7 runs-on swaps are syntactically correct and consistent. One question needs a clear answer before this can be approved.

The four slack-notifications jobs all carry the comment # Public GH runner is required, runners starting with sonar-* do not support this action. That comment was originally written to explain why those jobs used a GitHub-hosted runner (github-ubuntu-latest-s) instead of an internal sonar-* runner. With this PR the comment is preserved but the runner is now warp-custom-ubuntu-24-04 — a WarpBuild runner, not a standard GitHub-hosted runner. It's worth confirming whether rtCamp/action-slack-notify works on WarpBuild runners before merging, since the action's requirement may be specific to GitHub-hosted infrastructure.

Additionally, SubmitReview.yml and RequestReview.yml still reference github-ubuntu-latest-s and were not updated. These files have the same structure as the migrated PullRequestClosed.yml and PullRequestCreated.yml. If the migration is intended to be complete, those two files need to be included.

🗣️ Give feedback

Comment thread .github/workflows/build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant