ECHOES-1311 Pass brand value to build step in unified dogfooding workflow#687
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5860a48 to
b814a94
Compare
SummaryThis PR updates CI/CD workflows to support design token branding in the unified dogfooding pipeline. It makes two key changes:
The env var addition is the feature work; the runner change appears to enable or accompany that feature. What reviewers should knowWhere to look:
Things to verify:
Note: The PR description is empty — context about the ECHOES-1311 ticket would help clarify the intent and impact of the runner migration.
|
There was a problem hiding this comment.
LGTM! ✅
Straightforward and correct fix. The DESIGN_TOKEN_BRAND env var is required by design-tokens/build.js (it calls process.exit(1) when missing), so the unified dogfooding workflow was broken before this PR. The value Brand-A matches what build.yml already uses, which is consistent.
The runner migration from sonar-s-public to sonar-s in both workflows appears intentional and consistent.
|





The build step in the unified dofgooding workflow is missing the now-mandatory brand value.
Also, the sonar-s-public runners have been deprecated in favor of sonar-s, which can now handle public repositories.
A run of the dogfooding workflow on this PR's branch shows that it works: https://github.com/SonarSource/echoes-react/actions/runs/25716453852