Skip to content

ECHOES-1239 Fix header Title spacing#655

Merged
jeremy-davis-sonarsource merged 1 commit intomainfrom
jay/page-header-fix
Mar 20, 2026
Merged

ECHOES-1239 Fix header Title spacing#655
jeremy-davis-sonarsource merged 1 commit intomainfrom
jay/page-header-fix

Conversation

@jeremy-davis-sonarsource
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 20, 2026

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit aaf2ff8
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/69bd275e46926f00082fb9b3
😎 Deploy Preview https://deploy-preview-655--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Mar 20, 2026

ECHOES-1239

@sonarqube-next
Copy link

@jeremy-davis-sonarsource jeremy-davis-sonarsource marked this pull request as ready for review March 20, 2026 10:58
@sonar-review-alpha
Copy link

sonar-review-alpha bot commented Mar 20, 2026

Summary

Increases the gap spacing in the PageHeaderTitle component from dimension-space-50 to dimension-space-100. This is a single-line CSS adjustment to the flex layout that doubles the spacing between items in the header title, addressing the spacing issue described in ECHOES-1239.

What reviewers should know

This is a minimal, focused change: only the StyledPageHeaderTitle component's gap property in HeaderTitle.tsx is modified. The change uses the existing design system spacing token, so no new values are introduced. Visual testing of the header title area in different contexts (various title lengths, with/without icons) would be helpful to confirm the spacing improvement looks right.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonar-review-alpha
Copy link

sonar-review-alpha bot commented Mar 20, 2026

Summary

Increases the gap spacing in the page header title component from dimension-space-50 to dimension-space-100 to improve visual spacing between title elements.

What reviewers should know

Single-line change in HeaderTitle.tsx modifying the gap property of the StyledPageHeaderTitle styled component. This is a visual-only adjustment with no behavioral impact. Visual testing (checking that the header title elements have more breathing room) is the key verification needed.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@sonar-review-alpha
Copy link

sonar-review-alpha bot commented Mar 20, 2026

Summary

Increases the gap spacing between items in the page header title from dimension-space-50 to dimension-space-100. This is a CSS-only change that improves the visual spacing of the header title layout.

What reviewers should know

All changes are contained in HeaderTitle.tsx. The gap property in StyledPageHeaderTitle was adjusted to use a larger spacing constant. Visual testing of the header title in the UI is recommended to confirm the spacing looks correct.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: Clean, minimal change. Note that StyledPageHeaderTitle is shared by both PageHeaderTitle and ContentHeaderTitle (both route through the internal HeaderTitle component), so the updated gap applies to both — worth confirming that the increased spacing is intentional for both variants.

🗣️ Give feedback

@jeremy-davis-sonarsource jeremy-davis-sonarsource merged commit afc33a7 into main Mar 20, 2026
13 checks passed
@jeremy-davis-sonarsource jeremy-davis-sonarsource deleted the jay/page-header-fix branch March 20, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants