Refactor TMDb imports to use custom client#14
Open
SomeSourceCode wants to merge 2 commits intodevelopfrom
Open
Refactor TMDb imports to use custom client#14SomeSourceCode wants to merge 2 commits intodevelopfrom
SomeSourceCode wants to merge 2 commits intodevelopfrom
Conversation
The wrapper was not up to date and provided no sensible abstraction. It also didn't always work as expected, so it was used alongside custom http requests.
SomeSourceCode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the wrapper with custom HTTP requests via a
TmdbClient. The number of API calls is reduced to the minimum, by using TMDb's append to response feature and passing json and context down to child importers.