Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents SolidOS from attempting to load user preferences (and thus roles) after logout/reload when there is no authenticated user, addressing console errors described in issue #464.
Changes:
- Early-return
[]fromgetUserRoles()whenauthn.currentUser()is not set. - Pass the current user (
me) intoensureLoadedPreferencesto avoid triggering login/prefs flows unnecessarily.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #464
This PR resolves the error that comes up in the console when the user logs out and the browser reloads it still tries to get the User Roles which tries to load the preferences. When a user isn't logged in it should just return and not load preferences.
i was able to test this in SolidOS local.