Skip to content

a different approach to publicPath #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timea-solid merged 1 commit into from
Feb 5, 2026
Merged

a different approach to publicPath #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- name: Build with GitHub Pages publicPath
run: npm run build
env:
PUBLIC_PATH: /mashlib/dist/
- run: npm run build
- run: npm run bundlesize
- name: Save build
if: matrix.node-version == 20
Expand Down
6 changes: 3 additions & 3 deletions webpack.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ const common = {
target: 'web',
output: {
path: path.resolve(process.cwd(), 'dist'),
// Use PUBLIC_PATH env var for deployment (e.g., '/mashlib/dist/' for GitHub Pages)
// Defaults to '/' for local development and production
publicPath: process.env.PUBLIC_PATH || '/',
// 'auto' determines the public path at runtime based on the script's location
// This works for both the HTML file and dynamically loaded chunks
publicPath: 'auto',
library: {
name: 'Mashlib',
type: 'umd'
Expand Down