-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor styles to CSS #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SharonStrats
wants to merge
28
commits into
feature/dev-env
Choose a base branch
from
refactor/styles-separateCSS
base: feature/dev-env
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4e04ec8
created style file
SharonStrats 0145588
moved to index file
SharonStrats 0023072
webpack prod config
SharonStrats d2b71ec
install webpack helpers
SharonStrats db73294
mod package json
SharonStrats b9864b0
add css import
SharonStrats 3fdd307
Merge branch 'feature/dev-env' into refactor/styles-separateCSS
SharonStrats 048d738
moved styles
SharonStrats e8a9afe
Merge branch 'main' into refactor/styles-separateCSS
SharonStrats ce7e0b7
Potential fix for pull request finding
SharonStrats 9583127
icon var size
SharonStrats 42e0bb5
Merge branch 'refactor/styles-separateCSS' of https://github.com/Soli…
SharonStrats b8572cb
reverted back to folderPane
SharonStrats 77fd09c
change main file to match build
SharonStrats 4a69569
fixed dev loader
SharonStrats 4bddad2
css declarations
SharonStrats af06e32
update tsconfig
SharonStrats 85c7725
changed webpack entry
SharonStrats 6570739
changed class name
SharonStrats 39d8381
Merge branch 'feature/dev-env' into refactor/styles-separateCSS
SharonStrats a549411
add types and build to package
SharonStrats 7b88642
Update src/folderPane.ts
SharonStrats 8b2dc94
Update src/styles/utilities.css
SharonStrats 9523f53
Update src/styles/folderPane.css
SharonStrats 76462b1
add declarations to package
SharonStrats 1389a5a
Update src/styles/folderPane.css
SharonStrats 0e842f0
Merge branch 'refactor/styles-separateCSS' of https://github.com/Soli…
SharonStrats dccf8da
removed module
SharonStrats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| declare module '*.css' { | ||
| const classes: Record<string, string>; | ||
| export default classes; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| .folderPaneInstancePane { | ||
| border-top: solid 1px #777; | ||
| border-bottom: solid 1px #777; | ||
| margin-top: var(--spacing-xs, 0.5em); | ||
| margin-bottom: var(--spacing-xs, 0.5em); | ||
| } | ||
| .folderPanePackageDiv { | ||
| border-top: 0.2em solid #ccc; | ||
| } | ||
|
|
||
| .folderPanePredicateCell { | ||
| min-width: 3em; | ||
| } | ||
|
|
||
| .folderPaneExplicitDropIcon { | ||
| width: var(--icon-base, 2em); | ||
| height: var(--icon-base, 2em); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| :root { | ||
| /* Shared utility variables (e.g., base icon size) */ | ||
| --icon-base: 2em; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| import path from 'path' | ||
| import { moduleRules } from './webpack.module.rules.mjs' | ||
| import { createRequire } from 'module' | ||
| import TerserPlugin from 'terser-webpack-plugin' | ||
| import CopyPlugin from 'copy-webpack-plugin' | ||
|
|
||
| const require = createRequire(import.meta.url) | ||
|
|
||
| const common = { | ||
| mode: 'production', | ||
| entry: './src/folderPane.ts', | ||
| module: { | ||
| rules: moduleRules, | ||
SharonStrats marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| externals: { | ||
| 'solid-ui': 'UI', | ||
| 'solid-logic': 'SolidLogic', | ||
| rdflib: '$rdf', | ||
| }, | ||
| resolve: { | ||
| extensions: ['.js', '.ts'], | ||
| fallback: { | ||
| path: require.resolve('path-browserify') | ||
| }, | ||
| }, | ||
| devtool: 'source-map', | ||
| } | ||
|
|
||
| const normalConfig = { | ||
| ...common, | ||
| mode: 'production', | ||
| output: { | ||
| path: path.resolve(process.cwd(), 'lib'), | ||
| filename: 'folder-pane.js', | ||
| library: { | ||
| type: 'umd', | ||
| name: 'FolderPane', | ||
| export: 'default', | ||
| }, | ||
| globalObject: 'this', | ||
| clean: true, | ||
| }, | ||
| plugins: [ | ||
| ...(common.plugins || []), | ||
| new CopyPlugin({ | ||
| patterns: [ | ||
| { | ||
| from: path.resolve('src/styles'), | ||
| to: path.resolve('lib/styles'), | ||
| }, | ||
| ], | ||
| }), | ||
| ], | ||
| optimization: { | ||
| minimize: false, | ||
| } | ||
| } | ||
|
|
||
| const minConfig = { | ||
| ...common, | ||
| mode: 'production', | ||
| output: { | ||
| path: path.resolve(process.cwd(), 'lib'), | ||
| filename: 'folder-pane.min.js', | ||
| library: { | ||
| type: 'umd', | ||
| name: 'FolderPane', | ||
| export: 'default', | ||
| }, | ||
| globalObject: 'this', | ||
| clean: false, | ||
| }, | ||
| plugins: [ | ||
| ...(common.plugins || []), | ||
| new CopyPlugin({ | ||
| patterns: [ | ||
| { | ||
| from: path.resolve('src/styles'), | ||
| to: path.resolve('lib/styles'), | ||
| }, | ||
| ], | ||
| }), | ||
SharonStrats marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ], | ||
| optimization: { | ||
| minimize: true, | ||
| minimizer: [ | ||
| new TerserPlugin({ | ||
| terserOptions: { | ||
| format: { | ||
| comments: false, | ||
| }, | ||
| }, | ||
| extractComments: false, | ||
| }) | ||
| ], | ||
| } | ||
| } | ||
|
|
||
| export default [normalConfig, minConfig] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.