Skip to content

Fix schedule pane not being displayed in the folder view. #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SharonStrats wants to merge 6 commits into
base: refactor/styles-separateCSS
Choose a base branch
from
Open

Fix schedule pane not being displayed in the folder view. #167

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef2fcd3
fixed dev loader
SharonStrats Mar 20, 2026
b5c6926
Merge branch 'refactor/styles-separateCSS' into fix/schedpane-not-dis…
SharonStrats Mar 20, 2026
d4dabf9
Merge branch 'refactor/styles-separateCSS' into fix/schedpane-not-dis…
SharonStrats Mar 20, 2026
1482ecc
look for details if no index
SharonStrats Mar 20, 2026
4a10886
Merge branch 'refactor/styles-separateCSS' into fix/schedpane-not-dis…
SharonStrats Mar 24, 2026
b5dd822
Merge branch 'refactor/styles-separateCSS' into fix/schedpane-not-dis…
SharonStrats Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/folderPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,36 @@ export default {

const thisDir = subject.uri.endsWith('/') ? subject.uri : subject.uri + '/'
const indexThing = kb.sym(thisDir + 'index.ttl#this')
if (kb.holds(subject, UI.ns.ldp('contains'), indexThing.doc())) {
const detailsThing = kb.sym(thisDir + 'details.ttl#event')
const indexDoc = indexThing.doc()
const detailsDoc = detailsThing.doc()
const hasIndexDoc = kb.holds(subject, UI.ns.ldp('contains'), indexDoc)
const hasDetailsDoc = kb.holds(subject, UI.ns.ldp('contains'), detailsDoc)
const folderViewThing = hasIndexDoc
? indexThing
: hasDetailsDoc
? detailsThing
: undefined

if (folderViewThing) {
const sourceLabel = hasIndexDoc ? 'index' : 'details-fallback'
console.log(
'View of folder will be view of indexThing. Loading ' + indexThing
'[folder-pane] using ' + sourceLabel + ' view subject: ' + folderViewThing
)
Comment on lines +103 to 106
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log runs on every render when index.ttl or details.ttl is present, which can be noisy in production and makes it harder to debug other issues. Consider removing it or gating it behind an explicit debug flag/logging facility so normal folder navigation doesn’t spam the console.

Copilot uses AI. Check for mistakes.
const packageDiv = div.appendChild(dom.createElement('div'))
packageDiv.classList.add('folderPanePackageDiv')
kb.fetcher.load(indexThing.doc()).then(function () {
kb.fetcher.load(folderViewThing.doc()).then(function () {
mainTable = packageDiv.appendChild(dom.createElement('table'))
context
.getOutliner(dom)
.GotoSubject(indexThing, true, undefined, false, undefined, mainTable)
.GotoSubject(
folderViewThing,
true,
undefined,
false,
undefined,
mainTable
)
})
return div
} else {
Expand Down