Add async_set_ev_charging_state endpoint #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endpoint can be used to start and stop a SolarEdge EV charger. Signed-off-by: Aric Cyr <3453844+acyr@users.noreply.github.com>
tronikos
requested changes
Jan 26, 2026
- refactor out common code in _async_ensure_smart_home_session - use exceptions for error handling - clean up comments Signed-off-by: Aric Cyr <3453844+acyr@users.noreply.github.com>
tronikos
requested changes
Jan 27, 2026
| This is required before accessing home automation APIs. | ||
| Login is performed and the Smart Home page is visited to set up session state if needed. | ||
| """ | ||
| _LOGGER.debug("Fetching home automation devices for site: %s", self.site_id) |
Collaborator
There was a problem hiding this comment.
This is wrong here. Move it to async_get_home_automation_devices
|
|
||
| url = f"https://monitoring.solaredge.com/services/m/api/homeautomation/v1.0/{self.site_id}/devices/{device_id}/activationState" | ||
| headers = { | ||
| "Cookie": f"SPRING_SECURITY_REMEMBER_ME_COOKIE={cookie.value}", |
Collaborator
There was a problem hiding this comment.
Do you need this? You extracted this cookie value from the session cookie jar so I don't see why you need to explicitly pass it in the header.
| # Ensure smart home session is established | ||
| try: | ||
| await self._async_ensure_smart_home_session() | ||
| except Exception as e: |
Collaborator
There was a problem hiding this comment.
Remove the try/except block. You already log it in _async_ensure_smart_home_session
| # Ensure smart home session is established | ||
| try: | ||
| await self._async_ensure_smart_home_session() | ||
| except Exception as e: |
Collaborator
There was a problem hiding this comment.
Remove the try/except block. You already log it in _async_ensure_smart_home_session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint can be used to start and stop a SolarEdge EV charger.