Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';
import { AdminFormCreateEventComponent } from './components/admin-form-create-event/admin-form-create-event.component';
import { AdminFormManageEventComponent } from './components/admin-form-manage-event/admin-form-manage-event.component';


const routes: Routes = [];
const routes: Routes = [
{ path: 'new/advertisingconfig', component: AdminFormCreateEventComponent },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've settled on a preference for: new/campaign, manage/campaign

I think that is clean and understandable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, i've updated it. Since I was able to use the tabs, this path might be better named something more general since it includes both create and manage functionalities. path: 'campaigns' Thoughts?

Copy link
Collaborator

@robertlb4 robertlb4 Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad Idea. I like the idea of having the 2 routes available for us. In the future we can use them to decide which tab we start on when the component loads. So, if a link form another part of the site goes to manage/campaign then it will go to the same component but start on the manage tab.

I see you are changing it in the other PR, so it will be fine here for now.

{ path: 'manage/advertisingconfig', component: AdminFormManageEventComponent}
];

@NgModule({
imports: [RouterModule.forRoot(routes)],
Expand Down
Loading