Add guardrail in case manifest file does not exist#93
Merged
Conversation
dacoburn
requested review from
cenobitedk and
philidem
and removed request for
a team
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.15.dev1Docker image: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
pvdz
approved these changes
Jun 30, 2025
| for manifest_data in package.manifestFiles: | ||
| manifest_file = manifest_data.get("file") | ||
| manifests += f"{manifest_file};" | ||
| if hasattr(package, "manifestFiles"): |
Member
There was a problem hiding this comment.
This could be simplified to else:, no?
|
|
||
| # Handle license generation | ||
| if diff is not None and diff.id != "no_diff_id" and config.generate_license: | ||
| if should_skip_scan and diff.id != "no_diff_id" and config.generate_license: |
Member
There was a problem hiding this comment.
Is this correct? Or did you mean to check for whether NOT should_skip_scan here?
dacoburn
added a commit
that referenced
this pull request
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Logic for only creating the license file if a diff scan was ran was incorrect
Fix
Changed logic for detection
Public Changelog
N/A