Skip to content

Conversation

@mtorp
Copy link
Contributor

@mtorp mtorp commented Sep 18, 2025

Changed

  • Rename --only-compute flag to --dont-apply-fixejs for socket fix, but keep old flag as an alias.

Fixed

  • Sanitize extracted git repository names to be compatible with the Socket API.

The Socket backend validates repository names to ensure they work with GitHub's naming rules. However, GitHub's constraints differ from other platforms like GitLab, so names that work on one platform may not work on another. The sanitizeName function modifies extracted repository names to be compatible with Socket/GitHub.

@mtorp mtorp requested review from barslev and jdalton September 18, 2025 07:05
@jdalton
Copy link
Contributor

jdalton commented Sep 18, 2025

The 🐉 are now slumbering. All is 🟢

@jdalton jdalton merged commit 95c8584 into main Sep 20, 2025
12 checks passed
@jdalton jdalton deleted the socket-fix-and-repo-name-adjustments branch September 20, 2025 18:13
@jdalton
Copy link
Contributor

jdalton commented Sep 20, 2025

@mtorp Merged to get the PR moving... however --dont-apply-fixes we can make it a more conventional --no-apply-fixes the negated form of a boolean (it's just a bit of a pain to put into the system). We do it for --no-banner and --no-spinner though so it's not uncharted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants