Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [Unreleased]

### Fixed
- invalid range in multiline comment locating

## [1.1.0]

### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ internal object MultilineCommentLocator {

comments.forEach {
val (start, end) = it
locations.add(PhraseLocation(start, end))
// Only include valid ranges where start precedes end
if (start < end) locations.add(PhraseLocation(start, end))
}

return locations.toSet()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,28 @@ internal class MultilineCommentLocatorTest {
assertEquals(1, result.size)
assertEquals(PhraseLocation(0, 8747), result[0])
}

@Test
fun `Returns empty when end delimiter precedes start`() {
val testCode = "*/resolvers/*"

val result = MultilineCommentLocator.locate(testCode)

assertEquals(0, result.size)
}

@Test
fun `Returns only valid comment ignoring misordered delimiters`() {
val testCode = """
/* valid comment */
searchCode("query", pathFilter: "*/resolvers/*")
""".trimIndent()

val result = MultilineCommentLocator.locate(testCode)

assertEquals(1, result.size)
assertEquals(PhraseLocation(0, 19), result[0])
}
}

private val complexComment =
Expand Down