fix issue where generic support for pla inherits bbl behaviour#413
Closed
ratdoux wants to merge 1 commit into
Closed
fix issue where generic support for pla inherits bbl behaviour#413ratdoux wants to merge 1 commit into
ratdoux wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
修复 Snapmaker Web 打印预处理页中,Generic Support For PLA 被发送为
PLA-S导致耗材匹配失败的问题。保留使用
full_print_config()生成完整、与颜色槽位对齐的耗材类型列表。在该 Web 匹配接口中使用原始
filament_type,避免把 Snapmaker 耗材映射成 Bambu 风格的PLA-S/PA-S支撑耗材类型。原因
get_filament_type()会把带有GFS00/filament_is_support的支撑 PLA 规范化为PLA-S,但 Snapmaker 设备端并没有PLA-S这种挂载耗材类型。因此 Generic Support For PLA 在切片配置中是支撑耗材,但设备端实际只会上报
PLA,导致打印预处理页出现耗材类型不匹配。Summary
Fix Snapmaker web preprint filament matching when Generic Support For PLA was sent as
PLA-S.Keep using
full_print_config()so the filament type list remains complete and aligned with filament/color slots.Use the raw configured
filament_typein this web matching payload to avoid sending Bambu-style support tokens such asPLA-S/PA-Sto Snapmaker devices.Why
get_filament_type()normalizes support PLA withGFS00/filament_is_supportintoPLA-S, but Snapmaker devices do not exposePLA-Sas a mounted filament type.Generic Support For PLA is a support filament in the slicer config, while the device reports the mounted material as
PLA, which caused the preprint matcher to reject an otherwise valid mapping.