Skip to content

Conversation

@az-smartling
Copy link
Contributor

@az-smartling az-smartling commented Dec 3, 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Smartling CLI by adding a new jobs command, specifically enabling users to track the progress of their translation jobs. Concurrently, it undertakes a refactoring effort to standardize how output parameters are handled across different commands, ensuring a more consistent and maintainable codebase for future development. These changes aim to provide more utility and a better user experience for managing translation workflows.

Highlights

  • New jobs progress Command: Introduced a new jobs command with a progress subcommand, allowing users to check the status and word count of translation jobs by their UID or name.
  • Centralized Output Parameter Handling: Refactored and centralized the logic for resolving output parameters (format, mode, template) into a new cmd/helpers/resolve/output_params.go module, improving consistency across various CLI commands.
  • Dependency Updates: Updated core dependencies, including github.com/Smartling/api-sdk-go and several golang.org/x modules, to their latest versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new jobs progress command to check the status of translation jobs. It also includes a significant refactoring to centralize the handling of output parameters. The refactoring is well-executed and improves code structure. However, the implementation of the new jobs progress command has some areas for improvement, including code duplication, redundant checks, and dead code. I've left specific comments with suggestions to address these points.

Comment on lines 78 to 80
if err != nil {
return err
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This if err != nil block is dead code. The err variable from the cmd.Parent().PersistentFlags().GetString("output") call on line 73 is already checked for nil on lines 74-76. This block can never be reached and should be removed.

@dimitrystd
Copy link
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

If multiple jobs share the same name, the most recent active job (not Canceled or Closed)
will be selected.

Output Formats:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@az-smartling I have updated the documentation for two new commands. Please review the new texts, but I want to draw your attention to these output formats. Of course, this text was generated by LLM, but I'm not sure if we should hard-code it into this command. Perhaps we should make this text a shared const and reuse it in all new commands. What are your thoughts on it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@az-smartling I didn't generate the updated documentation. I plan to do this in the master branch when we will merge all related PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@az-smartling I updated the Makefile because I keep having the same issue when I try to build something. Please let me know if this fix is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants