Skip to content

Matter Lock: Add clear user failure test during defaultSchedule#2950

Open
hcarter-775 wants to merge 1 commit intomainfrom
add/default-sched-clear-user-failure-test
Open

Matter Lock: Add clear user failure test during defaultSchedule#2950
hcarter-775 wants to merge 1 commit intomainfrom
add/default-sched-clear-user-failure-test

Conversation

@hcarter-775
Copy link
Copy Markdown
Contributor

Description of Change

Add test for ClearUser case where it fails to remove the credentials during the defaultSchedule creation.

Summary of Completed Tests

Test added

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Test Results

   72 files    506 suites   0s ⏱️
2 791 tests 2 791 ✅ 0 💤 0 ❌
4 679 runs  4 679 ✅ 0 💤 0 ❌

Results for commit e6cb0c6.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

File Coverage
All files 81%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 79%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/can_handle.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 68%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against e6cb0c6

Copy link
Copy Markdown
Collaborator

@HunsupJung HunsupJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conclusion is somewhat absurd, but it seems unavoidable for now. it would be better to separate setCredential and setYearDaySchedule as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants