Skip to content

IKEA Scroll: Populate subscribed attributes key to fix refresh #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickolas-deboom wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −1
Open

IKEA Scroll: Populate subscribed attributes key to fix refresh #2841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/scroll_utils/utils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
local im = require "st.matter.interaction_model"
local clusters = require "st.matter.clusters"
local scroll_fields = require "sub_drivers.ikea_scroll.scroll_utils.fields"
local switch_fields = require "switch_utils.fields"

local IkeaScrollUtils = {}

Expand All @@ -28,11 +29,18 @@ function IkeaScrollUtils.subscribe(device)
subscribe_request:with_info_block(ib)
end
end
local cluster_id = clusters.PowerSource.ID
local attr_id = clusters.PowerSource.attributes.BatPercentRemaining.ID
local ib = im.InteractionInfoBlock(
scroll_fields.ENDPOINT_POWER_SOURCE, clusters.PowerSource.ID, clusters.PowerSource.attributes.BatPercentRemaining.ID
scroll_fields.ENDPOINT_POWER_SOURCE, cluster_id, attr_id
)
subscribe_request:with_info_block(ib)
device:send(subscribe_request)

local subscribed_attrs = device:get_field(switch_fields.SUBSCRIBED_ATTRIBUTES_KEY) or {}
subscribed_attrs[cluster_id] = subscribed_attrs[cluster_id] or {}
subscribed_attrs[cluster_id][attr_id] = ib
device:set_field(switch_fields.SUBSCRIBED_ATTRIBUTES_KEY, subscribed_attrs)
end

return IkeaScrollUtils
12 changes: 12 additions & 0 deletions drivers/SmartThings/matter-switch/src/test/test_ikea_scroll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,4 +781,16 @@ test.register_message_test(
}
)

test.register_coroutine_test(
"Refresh necessary attributes",
function()
test.socket.capability:__queue_receive(
{mock_ikea_scroll.id, {capability = "refresh", component = "main", command = "refresh", args = {}}}
)
local read_request = clusters.PowerSource.attributes.BatPercentRemaining:read(mock_ikea_scroll, 0)
test.socket.matter:__expect_send({mock_ikea_scroll.id, read_request})
test.wait_for_events()
end
)

test.run_registered_tests()
Loading