Zigbee Switch: Add support/handling for Stateless Step Capabilities#2818
Open
Zigbee Switch: Add support/handling for Stateless Step Capabilities#2818
Conversation
|
Invitation URL: |
Test Results 72 files 492 suites 0s ⏱️ Results for commit 2023b46. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2023b46 |
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
2 times, most recently
from
535962c to
cf1fc47
Compare
|
Duplicate profile check: Warning - duplicate profiles detected. |
greens
force-pushed
the
feature/color_temp_range
branch
from
3d5baa4 to
8855768
Compare
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
2 times, most recently
from
c0a48c5 to
f4a7af9
Compare
wkhenon
requested review from
aleclorimer,
cjswedes,
greens,
hcarter-775,
nickolas-deboom,
pegor-karoglanian and
tpmanley
greens
reviewed
Mar 4, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
f10a277 to
1bbafc5
Compare
hcarter-775
reviewed
Mar 9, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
1bbafc5 to
21d5850
Compare
greens
reviewed
Mar 10, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Mar 11, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
4ad4ca3 to
75ef0dc
Compare
greens
reviewed
Mar 11, 2026
Comment on lines
+21
to
+22
| local kelvin_min = device:get_field(switch_utils.KELVIN_MIN); | ||
| local kelvin_max = device:get_field(switch_utils.KELVIN_MAX); |
Contributor
There was a problem hiding this comment.
these are only used to store one value until we get the second, the range attribute's value should be considered canonical over these.
Contributor
There was a problem hiding this comment.
I think this speaks to a small miss in how these fields are stored. They should be persisted. Otherwise, we cannot guarantee their existence for native handlers.
Therefore, this PR (or the native handler PR) should change these setters to:
device:set_field(KELVIN_MAX..endpoint, temp_in_kelvin, {persist = true})
and
device:set_field(KELVIN_MAX..endpoint, temp_in_kelvin, {persist = true})
greens
reviewed
Mar 11, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/can_handle.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
671071f to
2023b46
Compare
greens
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests