Matter Switch: Improve battery profiling #2724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a few changes to the way that devices supporting batteries are profiled: * subscribe to PowerSource.AttributeList rather than reading this attribute, to help prevent failed reads from causing issues with device profiling * update the profile within match_profile rather than power_source_attribute_list_handler * use existing structure for handling waiting for profiling data before attempting a profile update
|
Invitation URL: |
nickolas-deboom
commented
Jan 21, 2026
Test Results 71 files 482 suites 0s ⏱️ Results for commit b0ab7ba. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against b0ab7ba |
nickolas-deboom
commented
Jan 21, 2026
nickolas-deboom
commented
Jan 21, 2026
| end | ||
| if switch_utils.get_product_override_field(device, "is_climate_sensor_w100") then | ||
| profile_name = "3-button-battery-temperature-humidity" | ||
| end |
Contributor
Author
There was a problem hiding this comment.
It turns out that this is the only unique handling needed for this device (plus the existing logic in find_default_endpoint), so I was able to remove the extra block in power_source_attribute_list_handler
hcarter-775
reviewed
Jan 21, 2026
hcarter-775
reviewed
Jan 21, 2026
hcarter-775
reviewed
Jan 21, 2026
drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Jan 21, 2026
drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Jan 21, 2026
drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Jan 21, 2026
drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua
Outdated
Show resolved
Hide resolved
nickolas-deboom
force-pushed
the
matter-switch-improve-battery-profiling
branch
from
48c5b71 to
ac6e8e6
Compare
hcarter-775
reviewed
Jan 26, 2026
drivers/SmartThings/matter-switch/src/test/test_matter_multi_button.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Jan 27, 2026
hcarter-775
reviewed
Jan 28, 2026
nickolas-deboom
force-pushed
the
matter-switch-improve-battery-profiling
branch
from
155c0be to
b0ab7ba
Compare
hcarter-775
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a few changes to the way that devices supporting batteries are profiled:
PowerSource.AttributeListrather than reading this attribute, to help prevent failed reads from causing issues with device profilingmatch_profilerather thanpower_source_attribute_list_handler