Matter Switch: remove double init on device added#2339
Closed
Conversation
The device_added handler was calling device_init in order to account for situations where device_init was not called due to a race condition with the device cache. Since lifecycle events are now guaranteed and ordered with FW 58, we no longer need to depend on this extra init.
Merged
Test Results 68 files 447 suites 0s ⏱️ Results for commit 655ed87. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 655ed87 |
|
Channel deleted. |
aleclorimer
approved these changes
Aug 18, 2025
nickolas-deboom
approved these changes
Aug 18, 2025
hcarter-775
approved these changes
Aug 20, 2025
Contributor
|
Closing, duplicated: #2938 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device_added handler was calling device_init in order to account for situations where device_init was not called due to a race condition with the device cache. Since lifecycle events are now guaranteed and ordered with FW 58, we no longer need to depend on this extra init.
Type of Change
Checklist
Description of Change
Summary of Completed Tests