58 Unit test fixes for matter test cases#2311
Merged
nickolas-deboom merged 12 commits intotest/58-unit-test-fixesfrom Aug 13, 2025
Merged
58 Unit test fixes for matter test cases#2311nickolas-deboom merged 12 commits intotest/58-unit-test-fixesfrom
nickolas-deboom merged 12 commits intotest/58-unit-test-fixesfrom
Conversation
This change covers the matter test case updates associated with #2310.
|
Channel deleted. |
Test Results 68 files ± 0 448 suites +1 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit f39f3f7. ± Comparison against base commit 0fcd44c. This pull request removes 286 and adds 14 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
matter-appliance_coverage.xml
matter-button_coverage.xml
matter-energy_coverage.xml
matter-lock_coverage.xml
matter-media_coverage.xml
matter-rvc_coverage.xml
matter-sensor_coverage.xml
matter-switch_coverage.xml
matter-thermostat_coverage.xml
matter-window-covering_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 067efc5 |
This commit also includes a small fix for LuaLibs v15+.
nickolas-deboom
commented
Aug 6, 2025
Contributor
|
Tests are looking good. 👍 Looks like there are 3 failing tests still due to modular profile changes which I think fall outside the scope of these changes (and would be fixed by a different PR). |
Contributor
Author
Ah yeah, good catch - those will be fixed by #2326! |
cjswedes
approved these changes
Aug 11, 2025
Contributor
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
This is definitely an improvement. All my comments are not blocking for merge and are only really about making everything consistent for when we use disable_startup_messages and when we dont. If we are simulating a device join where we expect added/doConfigure, then we should disable the startup messages, but if we are avoiding added, and only need init/doConfigure, the preferred approach would be to let the test framework queue those events (doConfigure only queued if the device is not provisioned).
Contributor
Author
|
I'm going to leave these commits unsquashed within this PR but use Squash and Merge to merge into the main PR. |
nickolas-deboom
merged commit 6bb6f9f
into
test/58-unit-test-fixes
16 of 18 checks passed
|
Invitation URL: |
aleclorimer
pushed a commit
that referenced
this pull request
Aug 19, 2025
This commit covers the matter test case updates associated with #2310.
nickolas-deboom
added a commit
that referenced
this pull request
Aug 21, 2025
This commit covers the matter test case updates associated with #2310.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers the matter test case updates associated with #2310.