Fix disconnected UDP tracker sensors being marked as OK on reconnect#1866
Open
ImSapphire wants to merge 1 commit into
Open
Fix disconnected UDP tracker sensors being marked as OK on reconnect#1866ImSapphire wants to merge 1 commit into
ImSapphire wants to merge 1 commit into
Conversation
On firmware that sends SensorInfo packets every second / on reconnect, setUpSensor should take care of setting the status, otherwise for older firmware versions (or if a sensor info packet is dropped) marking the sensor as OK if we receive rotation info should be sufficient. Closes #871
ImSapphire
requested review from
ButterscotchV,
Erimelowo and
loucass003
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On firmware that sends SensorInfo packets every second / on reconnect, setUpSensor should take care of setting the status, otherwise for older firmware versions (or if a sensor info packet is dropped) marking the sensor as OK if we receive rotation info should be sufficient.
Closes #871