Deactivate feeder bridge with new enough driver, add 'bindings provider'#1806
Draft
ImSapphire wants to merge 16 commits intomainfrom
Draft
Deactivate feeder bridge with new enough driver, add 'bindings provider'#1806ImSapphire wants to merge 16 commits intomainfrom
ImSapphire wants to merge 16 commits intomainfrom
Conversation
github-actions
bot
added
Area: SteamVR Driver
ImSapphire
force-pushed
the
sapphire/reset-bindings
branch
from
a181a0b to
eff50e4
Compare
Also abstracts away the named pipe handling, and refactors it to allow multi-connection.
ImSapphire
force-pushed
the
sapphire/reset-bindings
branch
from
6539c8f to
f6ff768
Compare
github-actions
bot
added
the
Area: Application Protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bindings provider purely exists to facilitate binding commonly-used actions (such as yaw/full reset, (feet) mounting calibration, and toggle tracking) to controller buttons, similar to how the current feeder app does it.
The bindings provider uses Flatbuffers to send commands to the server. It will be autostarted by the server when a new enough driver which handles device feeding connects to the server, and it will deactivate the feeder bridge, meaning the existing feeder app, if still being started, should not interfere with anything.
When this is merged, there should probably be a PR prepared to the installer that will remove the feeder app.
Requires: SlimeVR/SlimeVR-OpenVR-Driver#69
Requires: SlimeVR/SolarXR-Protocol#205
TODO:
svr-at the beginning.