Revert TrackerResetsHandler & add comments#1748
Open
ButterscotchV wants to merge 3 commits intomainfrom
Open
Conversation
Member
Except Butterflies don't and we routinely use them upside-down. |
Member
|
Also maybe let's give all the corrections better names? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My changes to the euler order in #1595 probably messed things up quite bad for some people. I originally thought I messed things up big time, but I think it's mainly just the change to the euler order, where I made it so roll no longer affected yaw estimation, but pitch did... I'm guessing people just have their trackers tilted too far forward/backward.
Manual mounting orientation being applied after
attachmentFixmay also be a source of problems, since a change in one variable will affect the other.tl;dr: This will revert to the original behaviour but with acceleration fixed.