Skip to content

Revert TrackerResetsHandler & add comments#1748

Open
ButterscotchV wants to merge 3 commits intomainfrom
bscotch/revert-reset
Open

Revert TrackerResetsHandler & add comments#1748
ButterscotchV wants to merge 3 commits intomainfrom
bscotch/revert-reset

Conversation

@ButterscotchV
Copy link
Member

@ButterscotchV ButterscotchV commented Feb 14, 2026

My changes to the euler order in #1595 probably messed things up quite bad for some people. I originally thought I messed things up big time, but I think it's mainly just the change to the euler order, where I made it so roll no longer affected yaw estimation, but pitch did... I'm guessing people just have their trackers tilted too far forward/backward.

Manual mounting orientation being applied after attachmentFix may also be a source of problems, since a change in one variable will affect the other.

tl;dr: This will revert to the original behaviour but with acceleration fixed.

@ButterscotchV ButterscotchV self-assigned this Feb 14, 2026
@ButterscotchV ButterscotchV added Type: Bug Something isn't working Area: Skeletal Model Deals with the model of the skeleton and its pose Priority: High Important feature or blocks something important Area: Server Related to the server labels Feb 14, 2026
@Eirenliel
Copy link
Member

The reason that the changes I made worked at all seems to be because official SlimeVR trackers have a correct IMU rotation applied, so the actual value of attachmentFix will be approximately equal to the quaternion identity, therefore the heading correction will be approximately equal between IMU and bone spaces.

Except Butterflies don't and we routinely use them upside-down.

@Eirenliel
Copy link
Member

Also maybe let's give all the corrections better names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Server Related to the server Area: Skeletal Model Deals with the model of the skeleton and its pose Priority: High Important feature or blocks something important Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants