Make ignore buttons be session only in checklist #1675
Merged
+78
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loucass003
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
github-actions
bot
added
Area: GUI
ImSapphire
reviewed
Dec 13, 2025
Member
ImSapphire
left a comment
ImSapphire
left a comment
There was a problem hiding this comment.
Seems good, couldn't find any issues during testing
server/core/src/main/java/dev/slimevr/config/CurrentVRConfigConverter.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/config/ConfigManager.java
Outdated
Show resolved
Hide resolved
ImSapphire
approved these changes
Dec 18, 2025
ButterscotchV
approved these changes
Dec 26, 2025
Member
ButterscotchV
left a comment
ButterscotchV
left a comment
There was a problem hiding this comment.
Maybe we should consider having some kind of hint that the permanent ignore option is in the little settings menu? Not sure how to make it hint, but not direct people to end up at the same problem as before. My only thought is to make it show some sort of message if they've repeatedly ignored it, but I also think that'd be a pain to implement.
Member
Author
|
lets see how it goes as is. I dont have clean solutions and it might not be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.