Driver Cleanup 2: Electric Boogaloo#80
Open
ImSapphire wants to merge 19 commits into
Open
Conversation
ImSapphire
force-pushed
the
sapphire/cleanup
branch
from
4356737 to
e15a165
Compare
ImSapphire
force-pushed
the
sapphire/enforce-clang-format
branch
from
2bdba0c to
6752c9c
Compare
ImSapphire
force-pushed
the
sapphire/cleanup
branch
from
e15a165 to
0aeb4c6
Compare
ImSapphire
force-pushed
the
sapphire/cleanup
branch
from
70b2c8a to
2d68503
Compare
kitlith
requested changes
May 16, 2026
Member
kitlith
left a comment
kitlith
left a comment
There was a problem hiding this comment.
Sorry for the delay.
This overall looks very good, but I have one concern due to the introduction of fixed size arrays that needs to be fixed. I'll mark that one very clearly. The rest are optional and opinion based. I'll be happy to hit "Approve" after that's been fixed.
Comment on lines
+154
to
+156
| char write_buf[4096]; | ||
| send_buf_.Pop(write_buf, available); | ||
| connection_handle_->write(write_buf, static_cast<unsigned int>(available)); |
Member
There was a problem hiding this comment.
a thought that doesn't need to be implemented right now: can we write (potentially twice?) directly from the circular buffer instead of first copying to a linear buffer?
Member
There was a problem hiding this comment.
i think even more ideally that this would be a vectored write instead of up to two writes, but uvw doesn't expose libuv's vectored write capabilities atm.
ImSapphire
force-pushed
the
sapphire/cleanup
branch
from
2d68503 to
473a381
Compare
ImSapphire
force-pushed
the
sapphire/cleanup
branch
from
162bf17 to
dfddbf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.