Migrate raw pointers to unique_ptr and fix memory/stability issues#38
Open
crayy8 wants to merge 4 commits intoSleuthKitLabs:develop-4.14from
Open
Migrate raw pointers to unique_ptr and fix memory/stability issues#38crayy8 wants to merge 4 commits intoSleuthKitLabs:develop-4.14from
crayy8 wants to merge 4 commits intoSleuthKitLabs:develop-4.14from
Conversation
Member
crayy8
commented
Mar 24, 2026
crayy8
commented
- Replace raw pointer ownership with unique_ptr throughout the library: RegistryByteBuffer, ValueData, RegistryKey, RegistryValue, RegistryHiveFile, RegistryHiveBuffer, Cell, HBIN, REGFHeader, NKRecord, VKRecord, ValueListRecord
- Remove AutoCellPtrList and AutoHBINPtrList RAII wrappers now that unique_ptr handles lifetime automatically
- Add virtual destructor to BinaryBlock to prevent UB when deleting through base class pointer
- Fix integer overflow in ByteBuffer::read() bounds check via uint64_t cast
- Fix dangling pointer in RejistryException::what() by caching result in mutable member
- Fix RegistryHiveFile::getErrorMessage() to handle FormatMessageA failure
- Fix REGFHeader::getHBINs() to std::move unique_ptr into vector
- Refactor Rejistry test program to exercise both RegistryHiveFile and RegistryHiveBuffer through shared processRegistryHive() function
- Replace raw pointer ownership with unique_ptr throughout the library: RegistryByteBuffer, ValueData, RegistryKey, RegistryValue, RegistryHiveFile, RegistryHiveBuffer, Cell, HBIN, REGFHeader, NKRecord, VKRecord, ValueListRecord - Remove AutoCellPtrList and AutoHBINPtrList RAII wrappers now that unique_ptr handles lifetime automatically - Add virtual destructor to BinaryBlock to prevent UB when deleting through base class pointer - Fix integer overflow in ByteBuffer::read() bounds check via uint64_t cast - Fix dangling pointer in RejistryException::what() by caching result in mutable member - Fix RegistryHiveFile::getErrorMessage() to handle FormatMessageA failure - Fix REGFHeader::getHBINs() to std::move unique_ptr into vector - Refactor Rejistry test program to exercise both RegistryHiveFile and RegistryHiveBuffer through shared processRegistryHive() function
APriestman
approved these changes
Mar 24, 2026
- Replace raw pointer typedefs with unique_ptr equivalents across NKRecord, VKRecord, HBIN, SubkeyListRecord, ValueListRecord, RegistryKey, RegistryValue, ValueData, and RegistryHive - Remove AutoNKRecordPtrList and AutoVKRecordPtrList RAII wrappers - Return unique_ptr from getRoot(), getSubkeyList(), getValueList(), getValue(), getSubkeys(), and getValues() throughout the hierarchy - Add bounds check in HBIN::getCells() to prevent over-reading hbin - Delete copy assignment operators on Buffer and Record base classes - Replace NULL with nullptr in HBIN and RegistryByteBuffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.