Initial work on inner PDC support#8629
Open
ShaneBeee wants to merge 7 commits intoSkriptLang:feature/nested-pdcfrom
Open
Initial work on inner PDC support#8629ShaneBeee wants to merge 7 commits intoSkriptLang:feature/nested-pdcfrom
ShaneBeee wants to merge 7 commits intoSkriptLang:feature/nested-pdcfrom
Conversation
ShaneBeee
requested review from
APickledWalrus and
Absolutionism
and removed request for
a team
Absolutionism
requested changes
May 5, 2026
Comment on lines
+67
to
+68
| // I know you're not supposed to be here, but where SHOULD you go? | ||
| EventValues.registerEventValue(EditContainerEvent.class, PersistentDataContainer.class, EditContainerEvent::getContainer); |
Contributor
There was a problem hiding this comment.
You could move this into the PDCModule, that way you can access the EventValueRegistry from the SkriptAddon
or just make a registerEV function here and pass along the EVR, up to you
As long as it uses the new EventValue registration
Contributor
Author
There was a problem hiding this comment.
I'm going to leave it as is right now, because Sovde wants to rework it to not rely on event values.
Sovde: "i'm probably going to rework it so it doesn't rely on event-values at all"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently Skript's PDC support only supports setting specific types.
It does not allow for editing inner containers.
Solution
Added a section to allow editing inner containers.
This is greatly beneficial for organization.
Testing Completed
None... why? Cause I forgot. I will do those.
Supporting Information
Talked to Sovde on discord about this... I make base, he makes better. GO TEAM!
Completes: none
Related: none
AI assistance: none