Add support for non mob/player entities in EffLook#8553
Open
CJH3139 wants to merge 2 commits intoSkriptLang:dev/featurefrom
Open
Add support for non mob/player entities in EffLook#8553CJH3139 wants to merge 2 commits intoSkriptLang:dev/featurefrom
CJH3139 wants to merge 2 commits intoSkriptLang:dev/featurefrom
Conversation
CJH3139
requested review from
Burbulinis and
TheMug06
and removed request for
a team
skriptlang-automation
Bot
added
the
needs reviews
ShaneBeee
suggested changes
Apr 17, 2026
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Small things I noticed
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ShaneBeee
approved these changes
Apr 21, 2026
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Thanks for those changes.
At quick glance this looks good to me!
sovdeeth
requested changes
Apr 21, 2026
Comment on lines
+110
to
+112
| Location base = entity instanceof LivingEntity living ? living.getEyeLocation() : entity.getLocation(); | ||
| Location loc = base.add(vector); | ||
| entity.lookAt(loc.getX(), loc.getY(), loc.getZ(), entityAnchor); |
Member
There was a problem hiding this comment.
I'm a little suspicious of this. Can you explain + test this case to me and why living entities act different?
sovdeeth
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#8453
Solution
Added an else when the livingentity is neither a player nor a mob in PaperEntityUtils
Testing Completed
!spawn mannequin
!make last spawned mannequin look at me
(Also tested with armorstands)
Supporting Information
Completes: #8453
Related: none
AI assistance: none