Fix the inventory close reason expression#8463
Open
erenkarakal wants to merge 1 commit intodev/patchfrom
Open
Conversation
erenkarakal
requested review from
Absolutionism and
Pesekjak
and removed request for
a team
1 task
Efnilite
requested changes
Feb 26, 2026
| @Override | ||
| public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) { | ||
| public boolean init(Expression<?>[] expressions, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) { | ||
| if (!getParser().isCurrentEvent(InventoryCloseEvent.class)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
inventory close reasonalways returns none because it's not initialized correctlySolution
Fix the code to call EventValueExpression's init
Testing Completed
Manual testing
Supporting Information
Removed the classExists check since the class exists on 1.21.0 and above
Completes: #8462
Related: none
AI assistance: none