Fix missing call in GroupPatternElement stringification#8449
Open
APickledWalrus wants to merge 1 commit intodev/featurefrom
Open
Fix missing call in GroupPatternElement stringification#8449APickledWalrus wants to merge 1 commit intodev/featurefrom
APickledWalrus wants to merge 1 commit intodev/featurefrom
Conversation
APickledWalrus
added
the
bug
APickledWalrus
requested review from
Pesekjak and
sovdeeth
and removed request for
a team
sovdeeth
approved these changes
Feb 19, 2026
Pesekjak
approved these changes
Feb 19, 2026
Efnilite
added
the
patch-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #8391, GroupPatternElement was incorrectly implemented. The stringification properties were not passed along, resulting in default properties being used.
Solution
I have updated the method to properly stringify the pattern element.
Testing Completed
Updated the relevant JUnit Test to account for this case.
Supporting Information
Completes: none
Related: none
AI assistance: none