Skip to content

Allow converting entities to inventory holders#8439

Merged
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/convert-to-InvHolder
Mar 2, 2026
Merged

Allow converting entities to inventory holders#8439
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/convert-to-InvHolder

Conversation

@sovdeeth
Copy link
Member

Problem

running inventory of vehicle when riding a donkey returned nothing. Skript was trying to convert the vehicle expression to a player via commandsender -> player converter, since there was no entity->inventoryholder converter

Solution

Adds a non-chaining entity-invholder converter.

Testing Completed

Manual confirmation

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth requested a review from a team as a code owner February 12, 2026 20:08
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 12, 2026
@sovdeeth sovdeeth requested review from Absolutionism and TheMug06 and removed request for a team February 12, 2026 20:08
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Feb 12, 2026
@sovdeeth sovdeeth added the needs reviews A PR that needs additional reviews label Feb 12, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Feb 16, 2026
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Feb 16, 2026
@sovdeeth sovdeeth merged commit b9656a5 into SkriptLang:dev/patch Mar 2, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Mar 2, 2026
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

3 participants