Skip to content

Fix name of event-inv being wrong#8438

Merged
sovdeeth merged 3 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/allow-event-overrides-in-type-property-handlers
Mar 2, 2026
Merged

Fix name of event-inv being wrong#8438
sovdeeth merged 3 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/allow-event-overrides-in-type-property-handlers

Conversation

@sovdeeth
Copy link
Member

Problem

on inventory open:
  broadcast name of event-inventory
  wait 1 tick
  broadcast name of event-inventory

name is always "crafting" even if you currently have a gui open and you open another one on top
if you wait a tick its fine
!open new chest inventory named "abc" to all players
!open new chest inventory named "abcd" to all players
Crafting
abc
Crafting
abcd

Solution

Adds a default convert(event, T) method to the expression property handler so expressions can override behavior for event-specific values.

Testing Completed

Manual confirmation

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth requested a review from a team as a code owner February 11, 2026 21:32
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 11, 2026
@sovdeeth sovdeeth requested a review from a team as a code owner February 11, 2026 21:32
@sovdeeth sovdeeth requested review from Efnilite and UnderscoreTud and removed request for a team February 11, 2026 21:32
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Feb 12, 2026
@sovdeeth sovdeeth added the needs reviews A PR that needs additional reviews label Feb 12, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Feb 23, 2026
@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Mar 2, 2026
@sovdeeth sovdeeth merged commit 98e34a2 into SkriptLang:dev/patch Mar 2, 2026
9 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Mar 2, 2026
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Mar 2, 2026
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Mar 2, 2026
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

3 participants