Skip to content

Removing 'private' in favor of 'protected' and non-finalizing method#8429

Open
JakeGBLP wants to merge 8 commits intoSkriptLang:dev/patchfrom
JakeGBLP:patch-6
Open

Removing 'private' in favor of 'protected' and non-finalizing method#8429
JakeGBLP wants to merge 8 commits intoSkriptLang:dev/patchfrom
JakeGBLP:patch-6

Conversation

@JakeGBLP
Copy link
Contributor

@JakeGBLP JakeGBLP commented Feb 3, 2026

Problem

These modifiers stand in the way of addon customization without copying everything over.

Solution

Removal of final and deprivatizing

Testing Completed

No testing needed

Supporting Information

No reason not to


Completes: none
Related: none
AI assistance: none

@JakeGBLP JakeGBLP requested review from a team and APickledWalrus as code owners February 3, 2026 03:43
@JakeGBLP JakeGBLP requested review from cheeezburga and removed request for a team February 3, 2026 03:43
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Feb 3, 2026
@JakeGBLP
Copy link
Contributor Author

JakeGBLP commented Feb 3, 2026

I'm doing this on the browser so 2 commits are missing, hang on.

Copy link
Contributor

@Pesekjak Pesekjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this API should be possible to extend (I also needed this once), but either don't expose the fields via getters or provide proper explanation what it does (or rather returns in this case) as Function<String, String> getUnexpectedEntryMessage() doesn't say much. What do I apply this function to? What do you get in return?

Edit: now it is exposed it should definitely have documentation anyway, for the constructors also

@JakeGBLP
Copy link
Contributor Author

JakeGBLP commented Feb 3, 2026

I wanted to add javadocs but I've never really done that, how should I word them?

@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Feb 5, 2026
@sovdeeth
Copy link
Member

sovdeeth commented Feb 5, 2026

I wanted to add javadocs but I've never really done that, how should I word them?

General documentation guidelines apply. Describe stuff, note side effects, use java docs notation. Nothing special

@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants