Removing 'private' in favor of 'protected' and non-finalizing method#8429
Removing 'private' in favor of 'protected' and non-finalizing method#8429JakeGBLP wants to merge 8 commits intoSkriptLang:dev/patchfrom
Conversation
|
I'm doing this on the browser so 2 commits are missing, hang on. |
Removed final modifier
There was a problem hiding this comment.
I agree this API should be possible to extend (I also needed this once), but either don't expose the fields via getters or provide proper explanation what it does (or rather returns in this case) as Function<String, String> getUnexpectedEntryMessage() doesn't say much. What do I apply this function to? What do you get in return?
Edit: now it is exposed it should definitely have documentation anyway, for the constructors also
|
I wanted to add javadocs but I've never really done that, how should I word them? |
General documentation guidelines apply. Describe stuff, note side effects, use java docs notation. Nothing special |
Problem
These modifiers stand in the way of addon customization without copying everything over.
Solution
Removal of final and deprivatizing
Testing Completed
No testing needed
Supporting Information
No reason not to
Completes: none
Related: none
AI assistance: none