Remove Nullable disable from Png Code#3024
Open
stefannikolei wants to merge 1 commit into
Open
Conversation
I added a new Property to PngChunk --> DataSpan. On all places Data was used the same way. So we have the guard on this place and can just use it.
stefannikolei
commented
Nov 22, 2025
| public IMemoryOwner<byte> Data { get; } | ||
| public IMemoryOwner<byte>? Data { get; } | ||
|
|
||
| public ReadOnlySpan<byte> DataSpan |
Contributor
Author
There was a problem hiding this comment.
Do you have a better idea to to this? Or should I check for null at all consuming places?
Member
|
@stefannikolei I'm going to revisit nullability post v4 launch. I want to put some thought to each leftover instance. |
Contributor
Author
|
Let me know. I am happy to help. If you want you can create issues and assign some to me 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new Property to PngChunk --> DataSpan. On all places Data was used the same way. So we have the guard on this place and can just use it.
Prerequisites
Description