Skip to content

Add two-output graph for visualization.py. Add csv validation for dashboard.#52

Open
justushelo wants to merge 12 commits intoSimulation-Decomposition:mainfrom
justushelo:45-two-output-graph
Open

Add two-output graph for visualization.py. Add csv validation for dashboard.#52
justushelo wants to merge 12 commits intoSimulation-Decomposition:mainfrom
justushelo:45-two-output-graph

Conversation

@justushelo
Copy link
Copy Markdown
Contributor

Add two-output option for visualization.py similar to Matlab implementation. Add csv validation to dashboard to catch incorrect delimiters or incorrect column names. Closes #45. Closes #50.

Copy link
Copy Markdown
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments.

Created a new function for two-output visualization. Added a
try/except block for CSV parsing in the dashboard. If a wrong
delimiter or invalid character is detected, it loads stress.csv
to stop buffering and prevent reactive cascade crashes.

Closes Simulation-Decomposition#45
Closes Simulation-Decomposition#50
* Static client-side WASM-deployment (Closes Simulation-Decomposition#53)
  - Replaced Python/Jinja backend templates with fully static HTML.
  - Included light/dark theme toggle.
  - Added netlify.toml for Netlify build.
  - Added package.json for Netlify build triggers.
  - Added scripts/build_wasm.sh for installing dependencies,
    building SimDec wheel, converting Panel to Pyodide,
    and copying necessary files.
  - Needed to add data/stress.csv to panel/ for conversion to WASM.

* Fixed error handling with faulty CSV files (Closes Simulation-Decomposition#50)
  - Faulty files display error message
  - Faulty files keep buffering icon in UI

* Two-output graph (Closes Simulation-Decomposition#45)
  - Two-output graph is in a new function as in previous PR.
Updated the build_wasm.sh script to work with netlify
Checking file existence.
Updated to "serve": "python3..."
Added logging to the build_wasm.sh script for better debugging.
Updated the panel convert command to use a relative path for requirements.
Copy link
Copy Markdown
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, happy to merge otherwise!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, should we also use your new function for visualising 2 outputs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error messages Two-output graph call

2 participants