Skip to content

[3.0] Prevent gaps in the keys in the results of User::boardsAllowedTo() #9235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sesquipedalian merged 2 commits into from
May 25, 2026
Merged

[3.0] Prevent gaps in the keys in the results of User::boardsAllowedTo() #9235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa9f793
Revert "Minor fix in SMF\User::boardsAllowedTo()"
Sesquipedalian May 25, 2026
ae77884
Prevent gaps in the keys in the results of User::boardsAllowedTo()
Sesquipedalian May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,8 +2390,8 @@ public function boardsAllowedTo(string|array $permissions, bool $check_access =
// Maybe a mod needs to tweak the list of allowed boards on the fly?
IntegrationHook::call('integrate_boards_allowed_to', [&$boards, $deny_boards, $permissions, $check_access, $simple]);

// Ensure each permission's array is a simple list.
$boards = array_map(fn($board_list) => array_values((array) $board_list), $boards);
// Ensure there are no gaps in the keys.
$boards = $simple ? array_values($boards) : array_map(fn($board_list) => array_values($board_list), $boards);

return $boards;
}
Expand Down
Loading