Skip to content

[3.0] UUID base32 #9234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sesquipedalian merged 2 commits into from
May 22, 2026
+10 −53
Merged

[3.0] UUID base32 #9234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17dff6
Revert "fix base32 encode/decode"
Sesquipedalian May 22, 2026
ceff6c2
Ensures hex and base32 strings are always correct length in SMF\Uuid
Sesquipedalian May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 10 additions & 53 deletions Sources/Uuid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,42 +1058,19 @@ protected function adjustTimestamp(): int
* that PHP's base_convert() produces. This is different from basic base32,
* which is specified in RFC 4648, section 6.
*
* This implementation is optimized specifically for UUIDs:
*
* @param string $hex A hexadecimal string.
* @return string A base32hex string.
*/
protected static function encodeBase32Hex(string $hex): string
{
$bin = hex2bin($hex);
$alphabet = self::BASE32_HEX;
$buffer = 0;
$bits = 0;
$pos = 0;

// UUID Base32 is always 26 chars
$out = str_repeat('0', 26);

// UUIDs are always exactly 128 bits (16 bytes).
for ($i = 0; $i < 16; $i++) {
// Each input byte contributes 8 bits to a buffer.
$buffer = ($buffer << 8) | \ord($bin[$i]);
$bits += 8;

// Output characters consume 5 bits at a time. Remaining bits are carried forward between iterations.
while ($bits >= 5) {
$bits -= 5;

$out[$pos++] = $alphabet[($buffer >> $bits) & 31];
}
}
$b32 = '';

// UUID Base32 encoding always leaves remaining bits.
if ($bits > 0) {
$out[$pos] = $alphabet[($buffer << (5 - $bits)) & 31];
foreach (str_split(strrev($hex), 10) as $chunk) {
$b32 = str_pad(base_convert(strrev($chunk), 16, 32), 8, '0', STR_PAD_LEFT) . $b32;
}

return $out;
// Trim leading zeros if too long, but pad with leading zeros if too short.
return str_pad(ltrim($b32, '0'), 26, '0', STR_PAD_LEFT);
}

/**
Expand All @@ -1103,38 +1080,18 @@ protected static function encodeBase32Hex(string $hex): string
* that PHP's base_convert() produces. This is different from basic base32,
* which is specified in RFC 4648, section 6.
*
* This implementation is optimized specifically for UUIDs:
*
* @param string $b32 A base32hex string.
* @return string A hexadecimal string.
*/
protected static function decodeBase32Hex(string $b32): string
{
$buffer = 0;
$bits = 0;
$pos = 0;

// Decoded UUIDs are always exactly 16 bytes.
$out = str_repeat("\0", 16);
$hex = '';

// UUID Base32 strings are always exactly 26 chars.
for ($i = 0; $i < 26; $i++) {
$c = \ord($b32[$i]);

// Convert ASCII to base32 (0-9 => 0-9, a-v => 10-31).
$buffer = ($buffer << 5) | ($c <= 57 ? $c - 48 : $c - 87);

// Each Base32 character contributes 5 bits to a buffer.
$bits += 5;

// Consume output bytes 8 bits at a time.
if ($bits >= 8) {
$bits -= 8;

$out[$pos++] = \chr(($buffer >> $bits) & 0xFF);
}
foreach (str_split(strrev($b32), 8) as $chunk) {
$hex = str_pad(base_convert(strrev($chunk), 32, 16), 10, '0', STR_PAD_LEFT) . $hex;
}

return bin2hex($out);
// Trim leading zeros if too long, but pad with leading zeros if too short.
return str_pad(ltrim($hex, '0'), 32, '0', STR_PAD_LEFT);
}
}
Loading