GH-4: Introduce sound support #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puremin0rez
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds configurable (sound, volume, pitch) per announcement (across a message group) and per message. Note chat chat messages are no longer a simple string but rather an object (see config.yml updates). No special CHANGELOG entry for this since the current unreleased entry has the entire new config format...I tried for a bit to add a custom deserializer to allow either a simple string or
ChatMessageobject in the list but it really ended up not being worth the complexity....also fixes a bug where each online player would advance the current announcement for chat messages for silly reasons
Completes #4