-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/template merge #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added basic project template * Make gradle executable again * Fixed typos from templatizing SimpleHealthbars2
* Ensure the base jar is ready for use Standard jar is the full-fat jar with all dependencies (kotlin stdlib included) Added `nokt` task to create a shadowed jar excluding kotlin stdlib * Updated release action jar reference
* Update dependencies to latest and improve plugin artifacts Update java, kotlin, gradle, spigot, ktlint, etc Switch to incrementMinorIfNotOnRelease version incrementer Improved packaging/artifacts by providing a plugin jar that will load libs (via spigot's `libraries` in plugin.yml) and an "offline" shadowed/fat jar shadowJar dependency relocation to prevent classpath pollution Simplify automated CHANGELOG update by making the format predictable * \N sequence was not working for changelog regex, replace with negated \n * Use default 'v' tag prefix instead of 'release-' * Fix first tag link * Release version: 0.1.0 * Revert "Release version: 0.1.0" as it was just a test This reverts commit 919b163f1dc009ad4c7cb54e496ced292b201f05. * Add comment explaining the plugin.yml offline copy * Replace jcenter with mavenCentral
Update Action workflows to include a flow for manual releasing and automated publishing Update Gradle dependencies to latest--Gradle wrapper, kotlin, plugins, spigot-api Update README to include some basic instructions for using the template repo and example plugins
tajobe
commented
May 21, 2025
| jvmTarget = "1.8" | ||
| processResources { | ||
| // inject runtime libraries into online plugin variant | ||
| val libraries = configurations.runtimeClasspath.get().resolvedConfiguration.resolvedArtifacts |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Injecting libraries placeholder is a good candidate to move into the template repo. Without this, any libraries added to the gradle build need to be manually added to the plugin.yml libraries: list for the non-fat jar distribution to function.
Puremin0rez
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Fixed
...the list of commits is a bit weird since this involved a merge with
--allow-unrelated-histories, also making it hard to manually squash the commits...