Create protected ephemeral sequential ctx return path with GUID #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CreateProtectedEphemeralSequentialCtx function abstracts away the complexity to create a shared lock in a secure way. It creates the ephemeral node with a unique GUID prefix, and a monotonic counter because of it being sequential. However, if Zookeeper has a problem (connection loss for example) at the exact right/wrong time, the node could be created on the server, and the confirmation may never be returned to the client, which may leave the ephemeral node if the session doesn't expire before the client reconnects. To allow the client to rectify that problem, we return the prefixed path with the GUID, so it can delete it even if the function returns an error.
lbajolet-shopify
requested review from
ilikeorangutans,
pourtorabehsan and
wenogk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CreateProtectedEphemeralSequentialCtxfunction abstracts away the complexity to create a shared lock in a secure way. It creates the ephemeral node with a unique GUID prefix, and a monotonic counter because of it being sequential.However, if Zookeeper has a problem (connection loss for example) at the exact right/wrong time, the node could be created on the server, and the confirmation may never be returned to the client, which may leave the ephemeral node if the session doesn't expire before the client reconnects.
To allow the client to rectify that problem, we return the prefixed path with the GUID, so it can delete it even if the function returns an error.