-
Notifications
You must be signed in to change notification settings - Fork 53
Add renderMode object to PickupLocationItemApi #3674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2026-01-rc
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
12394f5 to
13089af
Compare
|
/snapit |
35f30b6 to
66ed2db
Compare
|
/snapit |
1 similar comment
|
/snapit |
66ed2db to
3248efc
Compare
|
/snapit |
2 similar comments
|
/snapit |
|
/snapit |
|
🫰✨ Thanks @james-a-c! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20260113163731" |
3248efc to
842956d
Compare
lrsterrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 We should change the base branch to be 2026-01-rc (unless you also need this feature available in 2025-10, but based on the threads I went through I don't think this is the case). 2026-01-rc is the branch we'll promote to 2026-01
| /** | ||
| * The render mode of a pickup location option item. | ||
| */ | ||
| export interface PickupLocationOptionItemRenderMode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we could add a type called something generic like RenderMode in packages/ui-extensions/src/surfaces/checkout/api/shared.ts as I'd imagine that the type used in ShippingOptionItemRenderMode will remain consistent and won't accidentally diverge in the future if not intended to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. A shared type makes sense here to avoid the duplication. I will update
|
Oh and also, we're trying to get away from the duplication, but the current flow for making changes to checkout ui extension types/docs is to add them to the equivalent directory in checkout-web under |
f53842d to
cbd5366
Compare
842956d to
99df43c
Compare
99df43c to
86ed045
Compare
Just updated to base branch to 2026-01-rc And no problem on making the shared type change in checkout-web as well! |
86ed045 to
d2c17b3
Compare
f53842d to
ae08722
Compare
d2c17b3 to
d0123ca
Compare
d0123ca to
c3cbb9a
Compare
|
@lrsterrett ready for another review! 🙂 |
|
/snapit |
1 similar comment
|
/snapit |

Background
Part of https://github.com/shop/issues-checkout/issues/9641
Closes https://github.com/shop/issues-checkout/issues/10513
Changes to the Delivery section through the delivery redesign experiment have created 2 locations for the pickup-location-option-item-render-after target to render extensions, one of them being in a modal. We need a way to inform the extensions that are being rendered in this target that they are currently in a modal (or not).
implementation in checkout-web can be found in this draft PR stack
Screenshots
Inline
In modal
Solution
Extend the same pattern we use for shipping-option-item-render-after by exposing the
renderModeobject on PickupLocationItemApiCreate a new shared
RenderModetype to be used in shipping-option-item + pickup-location-itemUpdate shipping-option-item to use the new shared type.
🎩
npm installoverlayproperty is availableChecklist