Skip to content

Update select options to match support on Shop/world#1439

Merged
aswamy merged 1 commit intomainfrom
02-04-update_select_options_to_match_support_on_shop_world
Feb 4, 2026
Merged

Update select options to match support on Shop/world#1439
aswamy merged 1 commit intomainfrom
02-04-update_select_options_to_match_support_on_shop_world

Conversation

@aswamy
Copy link
Contributor

@aswamy aswamy commented Feb 4, 2026

Summary

Closes Shopify/theme-tools#730

  • The group option is placed in the wrong place in the schema (it should be for each item)
    • I confirmed it by running shopify theme dev and seeing an error from Shop/world when you put group in the wrong part for the schema

Tophat

  1. Make a copy of the existing setting.json in your cache if it exists
    • mv ~/Library/Caches/theme-liquid-docs-nodejs/setting.json ~/Library/Caches/theme-liquid-docs-nodejs/setting.json.bk
  2. Move the file from this branch to the cache
    • cp schemas/theme/setting.json ~/Library/Caches/theme-liquid-docs-nodejs/setting.json
  3. Open a theme on VSCode/Cursor with the Shopify Liquid extension
  4. Create a section with the following content
{% schema %}
{
  "name": "Alok Section",
  "settings": [
    {
      "type": "select",
      "id": "select",
      "label": "Select",
      "options": [
        {
          "group": "Select Group 1",
          "label": "Option",
          "value": "option",
        },
        {
          "group": "Select Group 1",
          "label": "Option 2",
          "value": "option2",
        },
        {
          "group": "Select Group 2",
          "label": "Option 3",
          "value": "option3",
        },
        {
          "" // attempt code completion inside the quotes (you can press ctrl + space to force it)
        }
      ]
    },
    {
      "type": "radio",
      "id": "radio",
      "label": "Radio",
      "options": [
        {
          "label": "Option",
          "value": "option",
        },
        {
          "" // attempt code completion inside the quotes (you can press ctrl + space to force it)
        }
      ],
    }
  ],
  "presets": [
    {
      "name": "Alok Section",
    }
  ]
}
{% endschema %}
  1. Ensure when you attempt to code complete a new option in "select", you'd get "label", "value" and "group", but only "label" and "value" under the "radio" options
  2. Revert the cached file back to the original setting.json

Outcome

Before After
image.png image.png

Copy link
Contributor Author

aswamy commented Feb 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aswamy aswamy marked this pull request as ready for review February 4, 2026 20:56
@aswamy aswamy requested a review from a team as a code owner February 4, 2026 20:56
Copy link
Contributor

@graygilmore graygilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget that some of these are hand crafted 😅

(no 🎩)

@aswamy aswamy merged commit 68e8571 into main Feb 4, 2026
6 checks passed
@aswamy aswamy deleted the 02-04-update_select_options_to_match_support_on_shop_world branch February 4, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

group suggested in wrong place when building a select schema setting

2 participants